Adding Symfony 7 Support #1
Conversation
…tibility with Symfony 7.0
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @floriankraemer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces compatibility with Symfony 7, allowing the bundle to be used in projects leveraging the latest Symfony framework version. It updates dependency requirements and documentation to reflect this change. A known issue with an integration test related to exception handling, causing a segmentation fault on PHP 8.4, has been temporarily commented out, and the author is seeking assistance with its resolution.
Highlights
- Symfony 7 Compatibility: Updated composer.json to allow installation with Symfony 7 components.
- Documentation Update: README.md files (English and Chinese) have been updated to reflect support for Symfony 7.
- Temporary Test Disablement: A section of the ContainerAopTest.php integration test, specifically the exception handling part, has been commented out due to a segmentation fault encountered on PHP 8.4.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds support for Symfony 7 by updating the dependencies in composer.json and the README files. The changes to the dependencies seem correct for supporting both Symfony 6.4+ and 7.0+.
My review focuses on the changes in the integration test. A test case for exception handling has been commented out due to a segmentation fault. I've suggested using markTestSkipped instead, which is a better practice for temporarily disabling tests. I also noticed that the test cleanup logic was commented out, which should be re-enabled to prevent leaving temporary files. Finally, there's a minor formatting issue that I've pointed out.
Regarding the segmentation fault on PHP 8.4, since it's a development version, it might be a bug within PHP itself. Creating a minimal, reproducible example and reporting it to the PHP project could be helpful. Investigating for potential infinite recursion or memory issues within the AOP interception logic, particularly around exception and finally block handling, might also provide some clues.
1 participant
There is one problem remaining, maybe you can help to resolve it: In the integration test, the exception part is causing a segmentation fault on my system using PHP 8.4 and I could not yet figure out why. It's caused by
$service->throwError();.It actually works when using Github Actions, so I assume this is a problem with my specific PHP version or how it was compiled.